lkml.org 
[lkml]   [2008]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] mmc: at91_mci: add multiwrite switch
    On Fri, May 30, 2008 at 02:08:56PM +0200, Nicolas Ferre wrote:
    > at91_mci is capable of multiwrite. Enable it before it disappears.

    This doesn't look safe. MULTIWRITE is not about whether you can do
    multi-writes, but whether you can properly report how many bytes were
    successfully written to the card _and_ the card acknowledged as having
    been successfully written.

    It looks to me as if the AT91 MMC driver reports no bytes, or all
    bytes if the FIFO reports that it became empty, which presumably it
    may do if you're unable to keep the FIFO full?

    (Dropped Hans-JA¼rgen from the CC list since my mailer seems to corrupt
    the address.)

    If Pierre wants to remove the MULTIWRITE flag, I'd like to hear his
    solution for the pxamci driver, where the only way to ascertain how
    many bytes were transmitted may be to walk the SG list comparing the
    DMA pointer with what was in the hardware DMA engine at the time.
    Maybe.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-06-01 16:45    [W:0.021 / U:0.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site