lkml.org 
[lkml]   [2008]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] nommu: fix kobjsize() for SLOB and SLUB
    Hi Paul,

    Paul Mundt wrote:
    > Not until the page->index bits are killed, otherwise you aren't fixing
    > anything. SLOB on nommu with those page->index tests will automatically
    > oops today, before or after your patches. Until that's resolved, there's
    > no point in pretending like kobjsize() has been "fixed". As no one has
    > come up with a valid reason for those tests existing in the first place,
    > simply having your patches and killing the BUG_ON()'s seems ok.

    Sorry if I'm starting to sound like a broken record, but can you explain
    why removing the ->index bits are safe? I mean, if removing them is
    really okay, that means we don't hit that code path with SLAB at all?

    Paul Mundt wrote:
    > If we're not going to kill the BUG_ON()'s, then your patches are purely
    > cosmetic fixups with no behavioural change -- (ie, nommu is still hosed
    > on SLOB with current git).

    It fixes nommu with SLUB, doesn't it?

    Pekka


    \
     
     \ /
      Last update: 2008-06-01 10:03    [W:0.019 / U:32.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site