Messages in this thread | | | Date | Fri, 9 May 2008 18:09:44 +0800 | From | WANG Cong <> | Subject | Re: build issue #380 for v2.6.26-rc1-279-g28a4acb : mach-voyager: multiple definition of `phys_cpu_present_map' |
| |
On Fri, May 09, 2008 at 11:58:37AM +0200, Ingo Molnar wrote: > > >i've got the one below queued up but it's stalled as it could easily be >wrong and there's no ack from James yet and there's been discussion back >and forth. James, what do you suggest? >
Well, 'phys_cpu_present_map' of arch/x86/mach-voyager/voyager_smp.c is only used in arch/x86/mach-voyager/voyager_smp.c, other files under arch/x86/mach-voyager/ not.
And there's also a global 'phys_cpu_present_map', and is widely used by files under arch/x86/kernel/.
I check these two 'phys_cpu_present_map''s types, the one used by arch/x86/kernel/ files is not the one defined in arch/x86/mach-voyager/voyager_smp.c. So 'arch/x86/mach-voyager/voyager_smp.c::phys_cpu_present_map' should become static.
Thanks.
| |