lkml.org 
[lkml]   [2008]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: NFS infinite loop in filemap_fault()
On Thu, May 08, 2008 at 08:42:03PM +0200, Miklos Szeredi wrote:
> > > Index: linux.git/mm/filemap.c
> > > ===================================================================
> > > --- linux.git.orig/mm/filemap.c 2008-05-08 08:17:22.000000000 +0200
> > > +++ linux.git/mm/filemap.c 2008-05-08 08:19:59.000000000 +0200
> > > @@ -1461,6 +1461,12 @@ page_not_uptodate:
> > > */
> > > ClearPageError(page);
> > > error = mapping->a_ops->readpage(file, page);
> > > + if (!error && !PageUptodate(page)) {
> >
> > Shouldn't you have (!error || error != AOP_TRUNCATED_PAGE),
>
> That would be a rather useless condition (hint: '!error' means 'error == 0')
>
> > since the fs can
> > return AOP_TRUNCATED_PAGE if it needs vfs to try the readpage again?
>
> Yep, I din't touch the 'error != 0' codepath.
>

Doh sorry, I hadn't had my coffee yet.

Josef


\
 
 \ /
  Last update: 2008-05-08 20:47    [W:0.035 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site