Messages in this thread | | | Date | Thu, 8 May 2008 14:29:47 -0400 | From | Josef Bacik <> | Subject | Re: NFS infinite loop in filemap_fault() |
| |
On Thu, May 08, 2008 at 08:42:03PM +0200, Miklos Szeredi wrote: > > > Index: linux.git/mm/filemap.c > > > =================================================================== > > > --- linux.git.orig/mm/filemap.c 2008-05-08 08:17:22.000000000 +0200 > > > +++ linux.git/mm/filemap.c 2008-05-08 08:19:59.000000000 +0200 > > > @@ -1461,6 +1461,12 @@ page_not_uptodate: > > > */ > > > ClearPageError(page); > > > error = mapping->a_ops->readpage(file, page); > > > + if (!error && !PageUptodate(page)) { > > > > Shouldn't you have (!error || error != AOP_TRUNCATED_PAGE), > > That would be a rather useless condition (hint: '!error' means 'error == 0') > > > since the fs can > > return AOP_TRUNCATED_PAGE if it needs vfs to try the readpage again? > > Yep, I din't touch the 'error != 0' codepath. >
Doh sorry, I hadn't had my coffee yet.
Josef
| |