lkml.org 
[lkml]   [2008]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.6.26-rc1
On Wed, 07 May 2008 01:36:09 +0200
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> Mauro Carvalho Chehab wrote:
> > On Tue, 06 May 2008 22:47:20 +0200
> > Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> >> Or another idea:
> >>
> >> Copy _all_ dependencies of drivers which can be selected by "...if
> ^^^^
> >> VIDEO_HELPER_CHIPS_AUTO" to VIDEO_HELPER_CHIPS_AUTO.
> >
> > I actually did this for tuners, on this changeset (still not at mainstream):
> > http://git.kernel.org/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commitdiff;h=d10b3c6817fb3fed8e6cd6d64d47c187a615c952
>
> Yes... Except that it is very dangerous to /move/ dependencies, as you
> are apparently doing in that patch. When you use "select" somewhere,
> you should generally /copy/ dependencies.
>
> Although something like
>
> config VIRTUAL_META_OPTION
> depends on REAL_DEPENDENCY
>
> config THE_REAL_THING
> depends on VIRTUAL_META_OPTION
>
> does work if THE_REAL_THING actually depends on REAL_DEPENDENCY, it is
> safer if this dependency stays there, i.e.
>
> config THE_REAL_THING
> depends on REAL_DEPENDECY
>
> or
>
> config THE_REAL_THING
> depends on REAL_DEPENDENCY && VIRTUAL_META_OPTION
>
> or whatever, or equivalent constructs involving "if"..."endif".
>
> (I presume that for example MEDIA_TUNER_TDA827X does indeed have a build
> dependency on DVB_CORE && I2C.)

No, the dependency of this file is currently wrong. In the case of those
tuners, all have the same dependencies: DVB or V4L and I2C. That's the reason
why I've removed the individual dependencies. Yet, two drivers need a select
(xc3028 and xc5000 needs to select FW_LOADER - so, only those two drivers are
also dependent of HOTPLUG).


Cheers,
Mauro


\
 
 \ /
  Last update: 2008-05-08 14:51    [W:0.053 / U:24.680 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site