Messages in this thread | | | Date | Thu, 8 May 2008 18:40:38 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] Mark res_counter_charge(_locked) with __must_check |
| |
On Thu, 08 May 2008 13:05:44 +0400 Pavel Emelyanov <xemul@openvz.org> wrote:
> Ignoring theirs return value may result in counter underflow > in the future - when the value charged will be uncharged (or in > "leaks" - when the value is not uncharged). > > This also prevents from using charging routines to decrement the > counter value (i.e. uncharge it) ;) > > (Current code works OK with res_counter, however :) ) > > Signed-off-by: Pavel Emelyanov <xemul@openvz.org> > nice check :)
BTW, res_counter_charge_locked() should be extern function ?
Thanks, -Kame
| |