Messages in this thread | | | Date | Wed, 7 May 2008 16:21:18 +0100 | From | Alan Cox <> | Subject | Re: [Linux-fbdev-devel] [PATCH 6/9] viafb: VIA Frame Buffer Device Driver |
| |
> +void delays(int count); > +void i2cWriteSdaScl(u8 sda, u8 scl); > +void i2cWriteScl(u8 scl); > +void i2cReadSdaScl(u8 *pSda, u8 *pScl);
Style is good, code looks clean
One big thing that needs fixing here is the function names. If the driver gets linked into the kernel then the symbols become global - and names like enableGPIO are asking for clashes. The viafb code is fine as it uses viafb_ as the function names. Possibly the helper functions should doo something similar.
We also have a generic i2c layer that might be usable but that is something that could be addressed in the future and isn't really an important detail.
>
| |