Messages in this thread | | | Date | Thu, 8 May 2008 00:39:18 +0200 | From | Pavel Machek <> | Subject | Re: 2.6.26, PAT and AMD family 6 |
| |
On Wed 2008-05-07 15:23:46, Yinghai Lu wrote: > > 2) HPA said it was bad idea > > hpa said white list is not a good idea.
And guess what your patch is doing?
+ switch (c->x86_vendor) { + case X86_VENDOR_AMD: + if (c->x86 >= 0xf && c->x86 <= 0x11) + set_cpu_cap(c, X86_FEATURE_PAT); + break; + case X86_VENDOR_INTEL: + if (c->x86 == 0xF || (c->x86 == 6 && c->x86_model >= 15)) + set_cpu_cap(c, X86_FEATURE_PAT); + break; + }
Seems like a whitelist to me. Will break with future CPUs. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |