lkml.org 
[lkml]   [2008]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] Fix cpumask_scnprintf_len() misdesign
    On Thu, 8 May 2008 02:14:50 +0400
    Alexey Dobriyan <adobriyan@gmail.com> wrote:

    > cpumask_scnprintf_len() takes "len" as an argument which is surprising,
    > If one follows call chain down it isn't length but number of bits. But
    > there is natural number of bits when talking about CPU masks -- NR_CPUS.
    > So use that.

    hm, maybe we should delete this function after all ;)

    > Remove 1:1 wrapper macro while I'm at it.

    There was a reason most of those 1:1 wrappers but yes, this one seems to be
    rather cargo-cultish.

    > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    > ---
    >
    > include/linux/cpumask.h | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > --- a/include/linux/cpumask.h
    > +++ b/include/linux/cpumask.h
    > @@ -289,11 +289,9 @@ static inline int __cpumask_scnprintf(char *buf, int len,
    > return bitmap_scnprintf(buf, len, srcp->bits, nbits);
    > }
    >
    > -#define cpumask_scnprintf_len(len) \
    > - __cpumask_scnprintf_len((len))
    > -static inline int __cpumask_scnprintf_len(int len)
    > +static inline int cpumask_scnprintf_len(void)
    > {
    > - return bitmap_scnprintf_len(len);
    > + return bitmap_scnprintf_len(NR_CPUS);
    > }
    >
    > #define cpumask_parse_user(ubuf, ulen, dst) \

    Does Paul have an opinion?

    (Well, Paul always has an opinion. But what is it?)


    \
     
     \ /
      Last update: 2008-05-07 23:39    [W:0.030 / U:1.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site