lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/56] microblaze_v2: Kconfig patches



> Hi Michal,
>
> On Sun, 2008-05-04 at 13:40 +0200, monstr@seznam.cz wrote:
>
>> +config EARLY_PRINTK_UARTLITE_ADDRESS
>> + hex "Physical address where UART Lite for early printk is mapped"
>> + depends on EARLY_PRINTK
>> + default "0x40100000"
>> + help
>> + Please enter physical address where your uart lite is mapped.
>
> I think this should default to 0x00000000, then in the early_printk code
> we can test for zero baseaddress and attempt some sensible fallback in
> that case (even to disable).

That's make sense to me.

>> +
>> +config HEART_BEAT
>> + bool "Heart beat function for kernel"
>> + help
>> + This option turns on/off heart beat kernel functionality on selected
>> + GPIO address.
>> +
>> +config HEART_BEAT_ADDRESS
>> + hex "Physical address for heart beat LED"
>> + depends on HEART_BEAT
>> + default "0x40600000"
>> + help
>> + Please enter physical address GPIO LED.
>
> Again, default address should be zero which is checked in the code (zero
> can disable). Prevent accesses to random memory locations in case of
> poorly configured kernel.

I'll add default option to HEART_BEAT to no and zero base address. I don't want to
add any checking code to this function except for #if solution.

>> +config HACK
>> + bool "Increase performance"
>> + default y
>
> As suggested by Grant, this sohuld be
>
> 1. renamed and described as something sensible
>
> SELF_MODIFYING_CODE_HACK

:-) nice name

> 2. Made condition on CONFIG_EXPERIMENTAL at very least.
>
>> +config OPT_LIB_FUNCTION
>> + bool "Optimalized lib function"
>> + default y
>> + help
>> + Allows turn on optimalized library function (memcpy and memmove).
>> + They are optimized by using unsigned alignment. This will work
>
> "Unsigned alignment"??
>
> Do you mean word-aligned?

Yes.

>> + fine if both source and destination are aligned on the same
>> + boundary. However, if they are aligned on different boundaries
>> + shifts will be necessary. This might result in bad performance
>> + on MicroBlaze systems without a barrel shifter.
>> +
>> +# This is still a bit broken - disabling for now JW 20070504
>> +config ALLOW_EDIT_AUTO
>> + bool "Permit Display/edit of Kconfig.auto platform settings"
>> + default n
>> + help
>> + Allows the editing of auto-generated platform settings from
>> + the Kconfig.auto file. Obviously this does not change the
>> + underlying hardware, so be very careful if you go editing
>> + these settings.
>> +
>> + Also, if you enable this, and edit various Kconfig.auto
>> + settings, YOUR CHANGES WILL BE LOST if you then disable it
>> + again. You have been warned!
>> +
>> + If unsure, say no.
>> +
>> +# Ok, the platform is chosen. Source the kconfig.auto to get all of the
>> +# system settings.
>
> Should be just "get all of the CPU settings", since we use OF to get the
> device tree.

OK.

>> diff --git a/arch/microblaze/platform/generic/Kconfig.auto b/arch/microblaze/platform/generic/Kconfig.auto
>> new file mode 100644
>> index 0000000..5dc8c15
>> --- /dev/null
>> +++ b/arch/microblaze/platform/generic/Kconfig.auto
>
>> +config XILINX_ERAM_SIZE
>> + hex "Memory size of XILINX_RAM"
>> + depends on XILINX_UNCACHED_SHADOW
>> + default 0x02000000
>
> Why does this depend on UNCACHED_SHADOW?

Because only UNCACHED_SHADOW wanted to know how big is memory. Current situation
is clear. Only consistent.c file wanted UNCACHED_SHADOW choise. I'll remove
this choice too.

> Regards,
>
> John

Thanks,
Michal


\
 
 \ /
  Last update: 2008-05-05 08:47    [W:0.308 / U:0.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site