lkml.org 
[lkml]   [2008]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH REPOST] CPA: Add statistics about state of direct mapping v4

>> +static unsigned long direct_pages_count[PG_LEVEL_NUM];
>> +
>> +void __meminit update_page_count(int level, unsigned long pages)
>
> Why __meminit ? This is used in split_large_page()

True. Can you please just remove it? I think it came when this
was still only used in early memory init.

[insert standard rant about the work:code size benefit ratio of these
fine grained section identifiers being far too high]

>> +{
>> +#ifdef CONFIG_PROC_FS
>
> Why keep an empty function when PROC_FS is disabled ?

So we don't have to add a ifdef in all the callers. Yes could probably
have an empty inline in that case in some header, but frankly that would
be a lot of code lines for saving only very minor code size in a very
unlikely CONFIG case.

-Andi



\
 
 \ /
  Last update: 2008-05-05 12:27    [W:0.014 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site