lkml.org 
[lkml]   [2008]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] OF: clean coding style - prom_parse.c
Hi All,

I fixed only part of coding style violation. Not all of them.

But you are right KERN_<level> is necessary.

For me is especially important to move these files from arch/powerpc to drivers/of.

M

>> /* Debug utility */
>> #ifdef DEBUG
>> static void of_dump_addr(const char *s, const u32 *addr, int na)
>> {
>> - printk("%s", s);
>> - while(na--)
>> - printk(" %08x", *(addr++));
>> - printk("\n");
>> + printk(KERN_INFO "%s", s);
>> + while (na--)
>> + printk(KERN_INFO " %08x", *(addr++));
>> + printk(KERN_INFO "\n");
>> }
>
> You've prefixed KERN_INFO before every address block.
>
> How about:
>
> print_hex_dump(KERN_<level>, s, DUMP_PREFIX_NONE, 4, addr, na, false);
>
>



\
 
 \ /
  Last update: 2008-05-04 10:19    [W:0.053 / U:3.544 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site