lkml.org 
[lkml]   [2008]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -mm] __ratelimit rewrite
From
From: Dave Young <hidave.darkstar@gmail.com>
Date: Sun, 4 May 2008 15:07:38 +0800

Hi Dave,

> @@ -76,8 +76,8 @@ extern void warn_on_slowpath(const char
> unlikely(__ret_warn_once); \
> })
>
> -#define WARN_ON_SECS(condition, state, secs) \
> - WARN_ON((condition) && __ratelimit(state))
> +#define WARN_ON_RATELIMIT(condition, state) \
> + WARN_ON((condition) && __ratelimit(state));
>
> #ifdef CONFIG_SMP
> # define WARN_ON_SMP(x) WARN_ON(x)

Are you sure you want that new semicolon there?

if (foo)
WARN_ON_RATELIMIT(...);
else

will result in a compile error.


\
 
 \ /
  Last update: 2008-05-04 09:57    [W:0.054 / U:0.684 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site