Messages in this thread Patch in this message | | | Date | Sat, 31 May 2008 20:15:33 +0400 | From | Oleg Nesterov <> | Subject | [PATCH] signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check |
| |
fae5fa44f1fd079ffbed8e0add929dd7bbd1347f changed do_signal_stop() to check SIGNAL_UNKILLABLE, this wasn't needed. If signal_group_exit() == F, the signal sent to SIGNAL_UNKILLABLE task must be already filtered out by the caller, get_signal_to_deliver(). And if signal_group_exit() == T we are not going to stop.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 26-rc2/kernel/signal.c~2_DSS_KILL_UNKILLABLE_CHECK 2008-05-31 14:54:32.000000000 +0400 +++ 26-rc2/kernel/signal.c 2008-05-31 16:03:39.000000000 +0400 @@ -1649,8 +1649,7 @@ static int do_signal_stop(int signr) } else { struct task_struct *t; - if (unlikely((sig->flags & (SIGNAL_STOP_DEQUEUED | SIGNAL_UNKILLABLE)) - != SIGNAL_STOP_DEQUEUED) || + if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) || unlikely(signal_group_exit(sig))) return 0; /*
| |