Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [patch 04/41] cpu ops: Core piece for generic atomic per cpu operations | Date | Fri, 30 May 2008 17:05:42 +1000 |
| |
On Friday 30 May 2008 15:38:25 Andrew Morton wrote: > On Thu, 29 May 2008 22:17:55 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote: > > But then its related to percpu operations and relies extensively on the > > various percpu.h files in asm-generic and asm-arch and include/linux > > Well that should be fixed. We should never have mixed the > alloc_percpu() and DEFINE_PER_CPU things inthe same header. They're > different. > > otoh as you propose removing the old alloc_percpu() I guess the end > result is no worse than what we presently have.
No, the worst thing is that this is a great deal of churn which doesn't actually fix the "running out of per-cpu memory" problem.
It can, and should, be fixed, before changing dynamic percpu alloc to use the same percpu pool.
Rusty.
| |