Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [patch 04/41] cpu ops: Core piece for generic atomic per cpu operations | Date | Fri, 30 May 2008 16:32:07 +1000 |
| |
On Friday 30 May 2008 15:17:55 Christoph Lameter wrote: > On Thu, 29 May 2008, Andrew Morton wrote: > > > local_irq_save(flags); > > > /* Calculate address of per processor area */ > > > p = CPU_PTR(stat, smp_processor_id()); > > > p->counter++; > > > local_irq_restore(flags); > > > > eh? That's what local_t is for? > > No that is what local_t exactly cannot do.
Yes, but this is local_t for dynamically allocated per-cpu vars. You've lost potential symmetry and invented a whole new nomenclature :(
local_ptr_inc() etc would be far preferable IMHO.
Cheers, Rusty.
| |