lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: RESEND: [PATCH] libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl


On Thu, 29 May 2008, Jeff Garzik wrote:
> >
> > It may be that you meant to make it an "else if" case, ie if there was no
> > IO-read, then you do a ndelay(400) as a last desperate case, but that's not
> > how your ata_sdd_sync() is actually written.
>
> The double-ndelay is definitely wrong, but we do need one. Technically it
> should -only- be a 400ns delay, but we also have a register read in there to
> make sure any posted writes are flushed.

Well, but the "read + delay" is already in ata_sdd_pause().

So it's "ata_sdd_sync()" that I think is bogus. Based on its name alone,
it shouldn't have a delay in it (except, as mentioned, possibly for the
fallback case where no port can be used for reading).

Linus


\
 
 \ /
  Last update: 2008-05-29 20:07    [W:0.928 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site