lkml.org 
[lkml]   [2008]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: BUG/OOPS: Double Lock in fsl_usb2_udc.c
From
Date
On Thu, 2008-05-29 at 02:23 -0700, David Brownell wrote:
> > On Wed, 28 May 2008 15:25:31 -0700 Eugene_Bordenkircher@selinc.com wrote:
> >
> > > Looking through other drivers, I have seen them releasing the lock
> > > immediately before calling disconnect(), however, without being an expert
> > > with this driver, I'm not entirely sure that is the best option here.
>
> Yeah, general policy is to drop the UDC spinlock whenever
> you call out to gadget driver code, since it may need to
> reenter for various reasons. (Though if drivers adopt some
> other locking policy that works, that should be fine too.
> Multiple locks don't seem to be needed.)
>

I will submit a patch to release the lock before calling disconnect().

- Leo



\
 
 \ /
  Last update: 2008-05-29 12:39    [W:0.039 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site