lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.6.26-rc: x86: pci-dma.c: use __GFP_NO_OOM instead of __GFP_NORETRY
> > -	page = dma_alloc_pages(dev, gfp, get_order(size));
> > + /* Don't invoke OOM killer or retry in lower 16MB DMA zone */
> > + page = dma_alloc_pages(dev,
> > + (gfp & GFP_DMA) ? gfp | __GFP_NORETRY : gfp, get_order(size));
> > if (page == NULL)
> > return NULL;
>
> I guess that's more specifally solving that-which-we-wish-to-solve.

Then the allocator could still be stuck in ZONE_DMA32 on 64bit.

Also d_a_c() does one "speculative" allocation, as in an allocation
where it knows the zone is too large for the mask but it tries anyways
because it often works. In that case too much trying is also not good.

-Andi


\
 
 \ /
  Last update: 2008-05-28 14:49    [W:0.107 / U:54.456 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site