Messages in this thread | | | Date | Wed, 28 May 2008 04:34:13 -0400 | From | Alan Cox <> | Subject | Re: [PATCH] video4linux: Push down the BKL |
| |
On Tue, May 27, 2008 at 10:37:01PM -0400, Andy Walls wrote: > I note the man page for open() doesn't list EBUSY as a valid errno. > However, the V4L2 API Spec does list EBUSY as a valid errno for V4L2 > open().
The posix spec doesn't limit the errors returnable this way - it says if the error is one of the ones listed it must return the error code stated so EBUSY is just fine.
> But in this case I can't. The driver probably shouldn't hold a lock and > suspend an open() indefinitely (IMO). It should say the device is BUSY
Agreed - especially if it is opened with O_NDELAY
| |