lkml.org 
[lkml]   [2008]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] libata: Handle bay devices in dock stations
Andrew Morton wrote:
>> + if (ACPI_FAILURE(acpi_evaluate_object(handle, "_EJ0",
>> + &arg_list, NULL)))
>> + printk(KERN_ERR "Failed to evaluate _EJ0!\n");
>> +}
>
> It would be better if the printk were to self-identify where it is
> coming from. If your kernel just blurts "Failed to evaluate _EJ0!"
> it's a bit of a head-scratcher.
>
> "libata-acpi: failed to evaluate _EJ0", perhaps?

ata_port_printk() would be better.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2008-05-29 05:11    [W:0.172 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site