Messages in this thread | | | Date | Thu, 29 May 2008 12:08:44 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] libata: Handle bay devices in dock stations |
| |
Andrew Morton wrote: >> + if (ACPI_FAILURE(acpi_evaluate_object(handle, "_EJ0", >> + &arg_list, NULL))) >> + printk(KERN_ERR "Failed to evaluate _EJ0!\n"); >> +} > > It would be better if the printk were to self-identify where it is > coming from. If your kernel just blurts "Failed to evaluate _EJ0!" > it's a bit of a head-scratcher. > > "libata-acpi: failed to evaluate _EJ0", perhaps?
ata_port_printk() would be better.
Thanks.
-- tejun
| |