Messages in this thread | | | Date | Wed, 28 May 2008 16:35:14 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [patch 06/11] x86: nmi_32/64.c - use apic_write_around instead of apic_write |
| |
On Sat, 24 May 2008, Cyrill Gorcunov wrote:
> apic_write_around will be expanded to apic_write in 64bit mode > anyway. Only a few CPUs (well, old CPUs to be precise) requires > such an action. In general it should not hurt and could be cleaned > up for apic_write (just in case) > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> > ---
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
Almost all local APIC write accesses must use apic_write_around(). The notable exceptions are appropriately guarded accesses to the ESR (there is no need ever to write to this register on Pentium processors and a read of the register has side-effects) and pieces of code known never to run on original Pentium processors.
Maciej
| |