Messages in this thread | | | Date | Wed, 28 May 2008 09:43:24 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH -mm 07/16] second chance replacement for anonymous pages |
| |
On Wed, 28 May 2008 20:03:11 +0900 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> > @@ -1129,7 +1141,11 @@ static unsigned long shrink_list(enum lr > > { > > int file = is_file_lru(lru); > > > > - if (lru == LRU_ACTIVE_ANON || lru == LRU_ACTIVE_FILE) { > > + if (lru == LRU_ACTIVE_FILE) { > > + shrink_active_list(nr_to_scan, zone, sc, priority, file); > > + return 0; > > + } > > + if (lru == LRU_ACTIVE_ANON && inactive_anon_low(zone)) { > > shrink_active_list(nr_to_scan, zone, sc, priority, file); > > return 0; > > } > > I made memcgroup noreclaim infrastructure today. > and, I found slightly odd behaviour. > > this condition increase OOM, because prevent active -> inactive moving > even though non global reclaim.
Good catch, I have applied your patch to my tree.
-- All rights reversed.
| |