[lkml]   [2008]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/3][-mm] add class_reclassify macro
    On Wed, May 21, 2008 at 1:21 AM, Greg KH <> wrote:
    > On Tue, May 20, 2008 at 03:02:32AM -0700, Andrew Morton wrote:
    >> On Tue, 20 May 2008 17:55:54 +0800 Dave Young <> wrote:
    >> > Converting class semaphore to mutex cause lockdep warnings due to
    >> > class_interface_register/unregister will possible call device_add/del
    >> Shouldn't we just fix that?
    > Um, no, that's a "feature" that some types of hardware and interfaces
    > require.
    > This is one reason I really don't like this type of conversion, it's
    > causing lots of problems for no known gain.
    > So I would just recommend dropping this patch set, the current "convert
    > class semaphore to a mutex" patch in the -mm tree is already causing
    > lockdep warnings, and trying to do something like this isn't really
    > going to solve the root problem here.

    At last, I decide to give up.

    Andrew, I could not do more for this issue now, you can drop the
    conversion patch if there's no suitable fix from others.


     \ /
      Last update: 2008-05-27 08:45    [W:0.025 / U:4.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site