Messages in this thread | | | Date | Tue, 27 May 2008 15:32:06 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/2] Added in MESSAGE notes for blktraces |
| |
On Tue, May 27 2008, Alan D. Brunelle wrote: > +#define blk_add_trace_msg(q, fmt, ...) \ > + do { \ > + struct blk_trace *bt = (q)->blk_trace; \ > + if (unlikely(bt)) \ > + __trace_note_message(bt, fmt, ##__VA_ARGS__); \ > + } while (0) > +#define BLK_TN_MAX_MSG 1024
BTW, I think we need to make this a lot smaller. Something like 128 chars should be enough, I think. 1K is just too much stack size to use here.
-- Jens Axboe
| |