Messages in this thread | | | Date | Sun, 25 May 2008 15:24:14 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 04/14] gfs2: dont call permission() |
| |
On Fri, May 23, 2008 at 12:00:26PM +0200, Miklos Szeredi wrote: > And that's true of lookup_one_len() as well, the last bit of horror > left in this permission() saga. It's called from lots of places, > often for doing things it's not at all meant to do (e.g. where caller > _knows_ it will return negative, etc...). One day maybe I'll have > strength to clean that up as well..., but not now.
lookup_one_len is not just a horror for permission, it's a nighmare in general. I'm not convinced any use of it except for silly renames is actually valid.
| |