lkml.org 
[lkml]   [2008]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] spi: Add OF binding support for SPI busses
On Sat, May 24, 2008 at 11:14 AM, Jochen Friedrich <jochen@scram.de> wrote:
> Grant Likely schrieb:
>> On Sat, May 24, 2008 at 12:26 AM, Grant Likely
>> <grant.likely@secretlab.ca> wrote:
>>> On Thu, May 22, 2008 at 8:05 PM, David Brownell <david-b@pacbell.net> wrote:
>>>> On Wednesday 21 May 2008, Anton Vorontsov wrote:
>>>>>> +++ b/drivers/spi/spi_of.c
>>>>> I think better placement for this is drivers/of, no?
>>>> Yes please.
>>> Okay, I wasn't sure. Will do.
>>
>> I'm having second thoughts about this. I think this code is more SPI
>> centric than it is OF centric. ie. it is usable by all spi masters in
>> an OF enabled system, but it is not usable by all OF devices in an SPI
>> enabled system. Or, in other words; it adds OF support to SPI, not
>> the other way around. I think drivers/spi is the right place for this
>> to live.
>
> Isn't the same true for drivers/of/gpio.c or drivers/of/of_i2c.c, as well?

I would argue 'yes!'

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.


\
 
 \ /
  Last update: 2008-05-24 19:37    [W:0.094 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site