Messages in this thread | | | Date | Fri, 23 May 2008 05:32:31 -0400 | From | Christoph Hellwig <> | Subject | Re: [patch 04/14] gfs2: dont call permission() |
| |
On Fri, May 23, 2008 at 10:12:06AM +0100, Steven Whitehouse wrote: > > I also suspect the conditional locking in gfs2_do_permission() could > > be cleaned up, due to the removal of the implicit recursion. > > > In order to be sure we'd have to check that there are no NFS code paths > left which can reach this code. That has usually been the reason for > conditional locking. > > In general the patch looks ok to me, and since it doesn't appear to > depend on anything else, I can drop it in my GFS2 git tree if that would > be helpful at this stage,
The NFS ->lookup inside filldir recursion is still there, but I plan to fix that for .27. You'll be Cc'ed on that patch.
| |