Messages in this thread Patch in this message | | | Subject | Re: [git patch] vfs: permission API cleanup (v2) | From | Tetsuo Handa <> | Date | Fri, 23 May 2008 13:30:54 +0900 |
| |
Subject: Reuse local variable in vfs_link().
Why not reuse "inode" which is assigned as
struct inode *inode = old_dentry->d_inode;
in the beginning of vfs_link() ?
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> --- fs/namei.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
--- vfs.orig/fs/namei.c +++ vfs/fs/namei.c @@ -2554,19 +2554,19 @@ static int vfs_link(struct dentry *old_d return -EPERM; if (!dir->i_op || !dir->i_op->link) return -EPERM; - if (S_ISDIR(old_dentry->d_inode->i_mode)) + if (S_ISDIR(inode->i_mode)) return -EPERM; error = security_inode_link(old_dentry, dir, new_dentry); if (error) return error; - mutex_lock(&old_dentry->d_inode->i_mutex); + mutex_lock(&inode->i_mutex); DQUOT_INIT(dir); error = dir->i_op->link(old_dentry, dir, new_dentry); - mutex_unlock(&old_dentry->d_inode->i_mutex); + mutex_unlock(&inode->i_mutex); if (!error) - fsnotify_link(dir, old_dentry->d_inode, new_dentry); + fsnotify_link(dir, inode, new_dentry); return error; }
| |