lkml.org 
[lkml]   [2008]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: kernel coding style for if ... else which cross #ifdef
Steve French wrote:
> A question splitting "else" and "if" on distinct lines vs. using an
> extra line and extra #else came up as I was reviewing a proposed cifs
> patch. Which is the preferred style?
>
> #ifdef CONFIG_SOMETHING
> if (foo)
> something ...
> else
> #endif
> if ((mode & S_IWUGO) == 0)
>
> or alternatively
>
> #ifdef CONFIG_SOMETHING
> if (foo)
> something ...
> else if ((mode & S_IWUGO) == 0)
> #else
> if ((mode & S_IWUGO) == 0)
> #endif
>

The former. Why? Because the latter case has unbalanced indentation:
to an editor, and to the human eye, it looks like the if in the #else
clause is a child to the "else if".

*However*, the best would really be if we changed Kconfig to emit
configuration constants what were 0/1 instead of undefined/defined.
That way we could do:

if (CONFIG_SOMETHING && foo) {
/* ... something ... */
} else if ((mode & S_IWUGO) == 0) {
/* ... */

... in many cases.

-hpa


\
 
 \ /
  Last update: 2008-05-24 01:15    [W:0.077 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site