Messages in this thread | | | Date | Fri, 23 May 2008 14:11:43 -0500 | From | "Steve French" <> | Subject | kernel coding style for if ... else which cross #ifdef |
| |
A question splitting "else" and "if" on distinct lines vs. using an extra line and extra #else came up as I was reviewing a proposed cifs patch. Which is the preferred style?
#ifdef CONFIG_SOMETHING if (foo) something ... else #endif if ((mode & S_IWUGO) == 0)
or alternatively
#ifdef CONFIG_SOMETHING if (foo) something ... else if ((mode & S_IWUGO) == 0) #else if ((mode & S_IWUGO) == 0) #endif
-- Thanks,
Steve
| |