Messages in this thread | | | Date | Thu, 22 May 2008 22:22:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 18/18] flag parameters: check magic constants |
| |
On Tue, 6 May 2008 17:18:07 -0400 Ulrich Drepper <drepper@redhat.com> wrote:
> --- a/net/socket.c > +++ b/net/socket.c > @@ -1219,6 +1219,13 @@ asmlinkage long sys_socket(int family, int type, int protocol) > struct socket *sock; > int flags; > > + /* Check the SOCK_* constants for consistency. */ > + BUILD_BUG_ON(SOCK_CLOEXEC != O_CLOEXEC); > + BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK); > + BUILD_BUG_ON((SOCK_MAX | SOCK_TYPE_MASK) != SOCK_TYPE_MASK); > + BUILD_BUG_ON(SOCK_CLOEXEC & SOCK_TYPE_MASK); > + BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
On alpha the
BUILD_BUG_ON(SOCK_NONBLOCK & SOCK_TYPE_MASK);
seems to have gone away, but now
BUILD_BUG_ON(SOCK_NONBLOCK != O_NONBLOCK);
is triggering.
| |