Messages in this thread | | | Date | Fri, 23 May 2008 12:04:52 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] snapshot: Push BKL down into ioctl handlers |
| |
> > > > + lock_kernel(); > > + > > Hm, well, I admit I'm a bit ignorant as far as the chardev locking is > concerned, but can you please tell me why would that be wrong if we didn't call > lock_kernel() here at all?
I've just been pushing the lock down. If the code already has enough internal locking for things like multiple ioctls in parallel then you can probably kill it entirely - but that needs someone who knows that driver well to decide and evaluate.
| |