lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH][TRIVIAL] r8169.c : fix misleading comment
Francois Romieu wrote:
> Emmanuel Colbus <emmanuel.colbus@ovh.net> :
>
>> Calling "PCI base addr 1" something that can actually lie at
>> PCI_BASE_ADDR_2 is misleading. Patch follows.
>>
>> signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
>>
>
> I do not approve:
> - the patch does not follow the comment style of the driver
> - the comment should be removed, not silly augmented
>
>
OK, makes sense. Second version :



This comment is misleading, since the region it refers to can actually
be PCI_BASE_ADDR_2. Remove it.

signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
---

diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old 2008-05-22 09:55:51.000000000 +0200
+++ drivers/net/r8169.c 2008-05-22 09:55:59.000000000 +0200
@@ -1632,7 +1632,6 @@
if (rc < 0)
goto err_out_disable_2;

- /* make sure PCI base addr 1 is MMIO */
if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
if (netif_msg_probe(tp)) {
dev_err(&pdev->dev,


\
 
 \ /
  Last update: 2008-05-22 10:09    [W:0.037 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site