lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/4] modules: proper cleanup of kobject without CONFIG_SYSFS
    Date
    On Thursday 22 May 2008 21:44:21 Denis V. Lunev wrote:
    > On Thu, 2008-05-22 at 19:20 +1000, Rusty Russell wrote:
    > > On Tuesday 20 May 2008 19:59:48 Denis V. Lunev wrote:
    > > > kobject: '<NULL>' (ffffffffa0104050): is not initialized, yet
    > > > kobject_put()
    > >
    > > AFAICT, module_sysfs_initialized is not ever set if !CONFIG_SYSFS.
    > >
    >
    > Basically you miss
    > static inline int mod_sysfs_init(struct module *mod)
    > {
    > return 0;
    > }
    > in include/linux/module.h
    >
    > So, without CONFIG_SYSFS a dummy stab for mod_sysfs_init is called.

    Ah, thanks for the explanation.

    Basically, this code is a dog's breakfast. There's no reason for this to be
    in the header, and no reason for the other mod_sysfs_init() not to be static.
    Ditto for most of the rest.

    Patch applied, thanks!
    Rusty.


    \
     
     \ /
      Last update: 2008-05-23 03:55    [W:0.021 / U:120.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site