Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 3/4] modules: proper cleanup of kobject without CONFIG_SYSFS | Date | Fri, 23 May 2008 11:51:39 +1000 |
| |
On Thursday 22 May 2008 21:44:21 Denis V. Lunev wrote: > On Thu, 2008-05-22 at 19:20 +1000, Rusty Russell wrote: > > On Tuesday 20 May 2008 19:59:48 Denis V. Lunev wrote: > > > kobject: '<NULL>' (ffffffffa0104050): is not initialized, yet > > > kobject_put() > > > > AFAICT, module_sysfs_initialized is not ever set if !CONFIG_SYSFS. > > > > Basically you miss > static inline int mod_sysfs_init(struct module *mod) > { > return 0; > } > in include/linux/module.h > > So, without CONFIG_SYSFS a dummy stab for mod_sysfs_init is called.
Ah, thanks for the explanation.
Basically, this code is a dog's breakfast. There's no reason for this to be in the header, and no reason for the other mod_sysfs_init() not to be static. Ditto for most of the rest.
Patch applied, thanks! Rusty.
| |