Messages in this thread | | | Date | Fri, 23 May 2008 00:00:02 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH 4/5] x86: move mp_bus_not_pci from mpparse.c |
| |
On Mon, 19 May 2008, Alexey Starikovskiy wrote:
> +++ b/arch/x86/kernel/io_apic_32.c > @@ -81,6 +81,12 @@ struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES]; > /* # of MP IRQ source entries */ > int mp_irq_entries; > > +#if defined (CONFIG_MCA) || defined (CONFIG_EISA) > +int mp_bus_id_to_type[MAX_MP_BUSSES]; > +#endif > + > +DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES); > +
> +++ b/arch/x86/kernel/io_apic_64.c > @@ -117,6 +117,8 @@ struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES]; > /* # of MP IRQ source entries */ > int mp_irq_entries; > > +DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES); > +
NAK for the whole series. If you want to move out stuff from mpparse, then please look for a useful place, which is
1) related to the code (mp_bus_not_pci has no obvious association to io_apic)
2) not duplicating code into 32/64 bit files again. We work hard on unifying and also distangling things and I refuse to accept a patch which moves code to a random place where it happens to compile.
Thanks,
tglx
| |