lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] au1000_eth: remove useless check
Francois Romieu wrote:
> The lifespan of the device covers the request_irq .. free_irq interval.
>
> The cast of a void * pointer is not needed either.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
>
> diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
> index 3634b5f..7023d77 100644
> --- a/drivers/net/au1000_eth.c
> +++ b/drivers/net/au1000_eth.c
> @@ -1239,12 +1239,7 @@ static int au1000_rx(struct net_device *dev)
> */
> static irqreturn_t au1000_interrupt(int irq, void *dev_id)
> {
> - struct net_device *dev = (struct net_device *) dev_id;
> -
> - if (dev == NULL) {
> - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
> - return IRQ_RETVAL(1);
> - }
> + struct net_device *dev = dev_id;
>

applied




\
 
 \ /
  Last update: 2008-05-22 12:25    [W:0.100 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site