lkml.org 
[lkml]   [2008]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] sky2: don't warn if page allocation fails
> 
> for (i = 0; i < sky2->rx_nfrags; i++) {
> - struct page *page = alloc_page(GFP_ATOMIC);
> + struct page *page = alloc_page(GFP_ATOMIC | __GFP_NOWARN);
>
> if (!page)
> goto free_partial;


IMO it's inappropriate to add these warnings to net drivers that
properly check all return values.

This approach is too maintenance intensive, and winds up fixing the same
problem over and over again -- a hint that the fix is in the wrong place.

Jeff




\
 
 \ /
  Last update: 2008-05-22 12:01    [W:0.045 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site