Messages in this thread Patch in this message | | | Date | Thu, 22 May 2008 00:22:20 -0400 | From | Steven Rostedt <> | Subject | [PATCH 5/5] ftrace: remove printks from irqsoff trace |
| |
Printing out new max latencies was fine for the old RT tracer. But for mainline it is a bit messy. We also need to test if the run queue is locked before we can do the print. This means that we may not be printing out latencies if the run queue is locked on another CPU. This produces inconsistencies in the output.
This patch simply removes the print altogether.
Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- kernel/trace/trace_irqsoff.c | 16 ---------------- 1 file changed, 16 deletions(-)
Index: linux-tip.git/kernel/trace/trace_irqsoff.c =================================================================== --- linux-tip.git.orig/kernel/trace/trace_irqsoff.c 2008-05-21 20:22:27.000000000 -0400 +++ linux-tip.git/kernel/trace/trace_irqsoff.c 2008-05-22 00:11:10.000000000 -0400 @@ -165,22 +165,6 @@ check_critical_timing(struct trace_array update_max_tr_single(tr, current, cpu); - if (!runqueue_is_locked()) { - if (tracing_thresh) { - printk(KERN_INFO "(%16s-%-5d|#%d): %lu us critical" - " section violates %lu us threshold.\n", - current->comm, current->pid, - raw_smp_processor_id(), - latency, nsecs_to_usecs(tracing_thresh)); - } else { - printk(KERN_INFO "(%16s-%-5d|#%d): new %lu us" - " maximum-latency critical section.\n", - current->comm, current->pid, - raw_smp_processor_id(), - latency); - } - } - max_sequence++; out_unlock: --
| |