lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: CFD: (was [PATCH] Standard indentation of arguments)
[Randy Dunlap - Wed, May 21, 2008 at 12:33:55PM -0700]
| On Wed, 21 May 2008 22:57:25 +0400 Cyrill Gorcunov wrote:
|
| > [Andrew Morton - Wed, May 21, 2008 at 10:46:44AM -0700]
| > | On Wed, 21 May 2008 08:09:39 -0400 Theodore Tso <tytso@mit.edu> wrote:
| > |
| > | > On Wed, May 21, 2008 at 06:32:06AM -0400, Christoph Hellwig wrote:
| > | > > On Wed, May 21, 2008 at 01:50:37AM -0700, Andrew Morton wrote:
| > | > > > Oh, what a marvellous way to encourage new contributors that was. Thank
| > | > > > you so much.
| > | > > >
| > | > > > For the record: Al speaks only for himself and a lack of expressed
| > | > > > disagrement from others should not be taken as agreement.
| > | > >
| > | > > But I'd like to second the opinion. This is getting a little too far.
| > | > > We should rather try to at least enforce very basic standards a lot of
| > | > > the crap shoved in doesn't follow instead of wanking around about exact
| > | > > placement of whitespaces.
| > | >
| > | > The real question is whether people who are wanking about whitespace
| > | > and spelling fixes in comments will graduate to writing real, useful
| > | > patches. If they won't, there's no point to encouraging them.
| > | >
| > |
| > | Guys, get a clue. It doesn't matter what that person did. It is the
| > | effect upon *all* other potential developers which is so damaging here.
| > | Not upon this individual.
| > |
| >
| > Btw, we have CodingStyle, SubmittingPatches and other, but why don't
| > we have something like KernelNewbieGuide? Don't get me wrong, but
| > there could be written all rules about - what is good to do, what is bad.
| > So a newbiew who wants to be usefull for kernel could read it and decide
| > what should be done. /Don't beat me ;) / And of course I know about
| > kernelnewbie.org but this (even quite short) document could help I think.
|
| I did a talk on Linux "social engineering" at {OSCON, IEEE NW something,
| and SCALE}. All about what (not) to do, how to do it, etc.
| Slides for it are available in http://www.xenotime.net/linux/mentor/ .
|
|
| ---
| ~Randy
|

Anrew, Randy, you just wrote KernelNewbiesGuide I think ;) There are
lot of internet sites which could help with what-to-do, and linux-mm.org
and kernel.bugzilla.org and more BUT what I've tried to say is that we
really have such document inside kernel tree (it could be really short)
like:

Which patches are not good for sending to LKML
----------------------------------------------
- Plain whitespace cleanup

Some rules just *known* only if you have an experience in LKML mailing
but if someone is sending _first_ patch he ever made he just doesn't know
that. That is all. So we need not a link to some inet resource BUT written
in file inside of kernel tree. But that is just my (personal) opinion.

- Cyrill -


\
 
 \ /
  Last update: 2008-05-21 21:49    [from the cache]
©2003-2011 Jasper Spaans