lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through
Christoph Lameter wrote:
> Why is it too big? Without your additions it is converting kmallocs
> inline to get_free_pages(). That results in a simple function call with
> two constant parameters.

Well, it's a PITA because of #include dependencies in any case. Is
moving it out-of-line a problem?

Christoph Lameter wrote:
> The patch touches the page struct uselessly. I think the PageSlab marking
> is useful for debugging but not for a production kernel.

Hmm, where? page_address() already references ->virtual. I suppose
CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a
CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from
kfree() as spotted by Vegard Nossum.)

Pekka


\
 
 \ /
  Last update: 2008-05-21 21:01    [W:0.035 / U:3.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site