lkml.org 
[lkml]   [2008]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] signals: sigqueue_free: don't free sigqueue if it is queued


On Wed, 21 May 2008, Roland McGrath wrote:
>
> Just properly removing the sigqueue entry and fixing the pending set is
> looking pretty good. Why was it we didn't do that?

I thought we didn't even know which queue it was pending on if it was
already on a thread-local queue. So we could remove the entry, but I
always objected to the games with the pending bit.

Just removing the entry I'm ok with, it was the (pointless and misleading)
use of recalc_sigpending() that started the whole discussion. The fact
that we then also have that "which signal is pending" bit in front of the
queue was something that came up later.

Linus


\
 
 \ /
  Last update: 2008-05-21 20:55    [W:0.247 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site