Messages in this thread |  | | Date | Tue, 20 May 2008 22:06:48 -0700 | From | "Paul Menage" <> | Subject | Re: [RFC][PATCH 2/3] memcg:: seq_ops support for cgroup |
| |
On Tue, May 20, 2008 at 5:28 PM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > With current interface, my concern is hotplug. > > File-per-node method requires delete/add files at hotplug. > A file for all nodes with _maps_ method cannot be used because > maps file says > == > The key/value pairs (and their ordering) should not > * change between reboots. > ==
OK, so we may need to extend the interface ...
The main reason for that restriction (not allowing the set of keys to change) was to simplify and speed up userspace parsing and make any future binary API simpler. But if it's not going to work, we can maybe make that optional instead.
> > And (*read) method isn't useful ;) > > Can we add new stat file dynamically ?
Yes, there's no reason we can't do that. Right now it's not possible to remove a control file without deleting the cgroup, but I have a patch that supports removal.
The question is whether it's better to have one file per CPU/node or one large complex file.
Paul
|  |