lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2 of 8] x86: fix warning on 32-bit non-PAE
    Date
    From
    Fix the warning:

    include2/asm/pgtable.h: In function `pte_modify':
    include2/asm/pgtable.h:290: warning: left shift count >= width of type

    On 32-bit PAE the virtual and physical addresses are both 32-bits,
    so it ends up evaluating 1<<32. Do the shift as a 64-bit shift then
    cast to the appropriate size. This should all be done at compile time,
    and so have no effect on generated code.

    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    ---
    include/asm-x86/page.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/asm-x86/page.h b/include/asm-x86/page.h
    --- a/include/asm-x86/page.h
    +++ b/include/asm-x86/page.h
    @@ -29,7 +29,7 @@
    /* to align the pointer to the (next) page boundary */
    #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK)

    -#define __PHYSICAL_MASK ((((phys_addr_t)1) << __PHYSICAL_MASK_SHIFT) - 1)
    +#define __PHYSICAL_MASK ((phys_addr_t)(1ULL << __PHYSICAL_MASK_SHIFT) - 1)
    #define __VIRTUAL_MASK ((1UL << __VIRTUAL_MASK_SHIFT) - 1)

    #ifndef __ASSEMBLY__



    \
     
     \ /
      Last update: 2008-05-20 11:09    [W:0.030 / U:32.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site