lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] posix timers: use SIGQUEUE_CANCELLED when the timer is destroyed
Date
> 	q->flags |= SIGQUEUE_CANCELLED;
> spin_lock_irqsave(lock, flags);
> q->flags &= ~SIGQUEUE_PREALLOC;

Just make it:

spin_lock_irqsave(lock, flags);
q->flags |= SIGQUEUE_CANCELLED;
q->flags &= ~SIGQUEUE_PREALLOC;

and we needn't wax philosophical about the meaning of locking rules. That
patch would have my ACK, but I concur with Linus about the undesireability
of the plain = version.


Thanks,
Roland


\
 
 \ /
  Last update: 2008-05-21 04:31    [W:0.082 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site