Messages in this thread | | | Subject | Re: [PATCH 15/15] rfkill: document rw rfkill switches and clarify input subsystem interactions | Date | Tue, 20 May 2008 19:18:58 +0200 | From | Ivo van Doorn <> |
| |
On Tuesday 20 May 2008, Henrique de Moraes Holschuh wrote: > > On Tue, 20 May 2008 12:09:08 +0200, "Ivo van Doorn" <ivdoorn@gmail.com> said: > > > +You should: > > > - rfkill_allocate() > > > - - input_allocate_polled_device() > > > + - modify rfkill fields (flags, name) > > > + - modify state to the current hardware state (THIS IS THE ONLY TIME > > > + YOU CAN ACCESS state DIRECTLY) > > > - rfkill_register() > > > - - input_register_polled_device() > > > > Wasn't it the plan to send the current hardware state as rfkill > > registration argument, > > so we can force drivers to send a valid state to rfkill? > > Yes, but IMHO we should do that in a future patch. That patch will touch > every rfkill driver, so I'd rather we do that later. IMHO it is best to get > the most important stuff merged, first... > > Then, in that future patch, we change the API, fix all in-tree drivers using > that API, and update the documentation to match the new API. For now, we > update the documentation to match the current API. > > What do you think?
Sounds good to me. :)
Ivo
| |