lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/15] rfkill: document rw rfkill switches and clarify input subsystem interactions
Date
From
On Tuesday 20 May 2008, Henrique de Moraes Holschuh wrote:
>
> On Tue, 20 May 2008 12:09:08 +0200, "Ivo van Doorn" <ivdoorn@gmail.com> said:
> > > +You should:
> > > - rfkill_allocate()
> > > - - input_allocate_polled_device()
> > > + - modify rfkill fields (flags, name)
> > > + - modify state to the current hardware state (THIS IS THE ONLY TIME
> > > + YOU CAN ACCESS state DIRECTLY)
> > > - rfkill_register()
> > > - - input_register_polled_device()
> >
> > Wasn't it the plan to send the current hardware state as rfkill
> > registration argument,
> > so we can force drivers to send a valid state to rfkill?
>
> Yes, but IMHO we should do that in a future patch. That patch will touch
> every rfkill driver, so I'd rather we do that later. IMHO it is best to get
> the most important stuff merged, first...
>
> Then, in that future patch, we change the API, fix all in-tree drivers using
> that API, and update the documentation to match the new API. For now, we
> update the documentation to match the current API.
>
> What do you think?

Sounds good to me. :)

Ivo


\
 
 \ /
  Last update: 2008-05-20 19:07    [W:0.097 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site