lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [X86] Remove unnecessary code in 64bit CPU identification.
On Tue, May 20, 2008 at 07:46:57AM -0700, H. Peter Anvin wrote:
> Dave Jones wrote:
> > There were no 64bit Transmeta CPUs made (and it'd be something of
> > a surprise if they started any time soon). To the best of my knowledge,
> > no CPU vendor cloned the 80860000 cpuid space claimed by Transmeta.
> > By removing this code, we can also eliminate calling cpuid 0x80000007 twice.
> >
> > Signed-off-by: Dave Jones <davej@redhat.com>
>
> I'd really like to avoid divergences between the 32-bit and 64-bit code
> if they can be avoided at this point. These codes need to be unified,
> not further split.

Umm, the 32 bit code has the per-vendor stuff removed from setup.c, and factored
out into per-vendor files in arch/x86/kernel/cpu/ Because the 64bit version
doesn't do that (yet), my removal of this code actually gets us closer to unification.
After my patch, neither of the setup.c files have the Transmeta bits :)

Dave

--
http://www.codemonkey.org.uk


\
 
 \ /
  Last update: 2008-05-20 17:29    [W:0.099 / U:0.084 seconds]
©2003-2011 Jasper Spaans