Messages in this thread | | | Date | Tue, 20 May 2008 07:54:10 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] Make |
| |
On Tue, 20 May 2008, Dave Jones wrote: > > Like this ? (I don't have a -mm handy, so guessed based on mm-commits mail, > patch uncompiled, but should dtrt if I understood your diff correctly) > > diff --git a/lib/list_debug.c b/lib/list_debug.c > index 4350ba9..d8dee53 100644 > --- a/lib/list_debug.c > +++ b/lib/list_debug.c > @@ -21,16 +21,14 @@ void __list_add(struct list_head *new, > struct list_head *next) > { > if (unlikely(next->prev != prev)) { > - printk(KERN_ERR "list_add corruption. next->prev should be " > + WARN(1, "list_add corruption. next->prev should be " > "prev (%p), but was %p. (next=%p).\n", > prev, next->prev, next); > - BUG(); > }
I think Arjan meant like
WARN(next->prev != prev, "list_add corruption. next->prev should be " "prev (%p), but was %p. (next=%p).\n", prev, next->prev, next);
without any "if()" statement at all.
Linus
| |