lkml.org 
[lkml]   [2008]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: b4aa54d951d38d7a989d6b6385494ef5ea7371d7 breaks some serial configurations
    I see... would be OK to move the asm/serial.h include to its original 
    position and to modify the asm-blackfin/serial.h in this way to avoid
    duplicate definition warnings, or would it be too ugly?:

    /*
    * include/asm-blackfin/serial.h
    */

    +#ifdef SERIAL_EXTRA_IRQ_FLAGS
    +#undef SERIAL_EXTRA_IRQ_FLAGS
    +#endif

    #define SERIAL_EXTRA_IRQ_FLAGS IRQF_TRIGGER_HIGH

    Regards,

    Javier

    Russell King escribió:
    > On Tue, May 20, 2008 at 10:07:11AM +0200, Javier Herrero wrote:
    >> Does the problem arise due to the change of inclusion order of
    >> asm/serial.h (from after 8250.h to before 8250.h) ?
    >
    > Yes. It was placed where it was because of the dependencies of
    > asm/serial.h on the code between the two places.
    >
    > The alternative solution is to get rid of the CONFIG_* compatibility
    > and update those asm/serial.h which reference the old symbols.
    > However, that's a larger patch.
    >

    --
    ------------------------------------------------------------------------
    Javier Herrero EMAIL: jherrero@hvsistemas.com
    HV Sistemas S.L. PHONE: +34 949 336 806
    Los Charcones, 17A FAX: +34 949 336 792
    19170 El Casar - Guadalajara - Spain WEB: http://www.hvsistemas.com

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2008-05-20 12:55    [W:8.277 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site