lkml.org 
[lkml]   [2008]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] fs: remove local variable copy of f_pos to enable thread-safe updates
On Fri, May 02, 2008 at 02:14:25AM -0700, Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@yahoo.com>
>
> Remove local variable copy of f_pos to enable thread-safe updates in
> implementation functions of system calls read, readv, write and writev.

... and we are back to square one with racy instances of ->read() that
will use *pos twice, leaving a window for e.g. lseek() to invalidate
e.g. wraparound tests. Not that deciding what to do at the end of
e.g. read() with lseek() happening in the middle would be fun anyway -
esp. since you don't remember the kind of seek it had been.

Go argue that with Linus.


\
 
 \ /
  Last update: 2008-05-02 11:35    [W:0.044 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site